Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document checks before sharing #1059

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Add document checks before sharing #1059

merged 3 commits into from
Mar 29, 2022

Conversation

georgimld
Copy link
Collaborator

@georgimld georgimld commented Mar 23, 2022

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

This PR fixes a bug where some checks was missing before sharing a document.
Following checks were added:

  • if document exists
  • if it is a document stored in the storage service

Closes #1053

- before sharing a document it should be checked if document exists and if it is a document stored in the storage service
@github-actions
Copy link

github-actions bot commented Mar 28, 2022

Warnings
⚠️ No CHANGELOG added.

Generated by 🚫 dangerJS against 2243b47

@georgimld georgimld assigned georgimld and unassigned Stezido Mar 28, 2022
@openkfwCI
Copy link

openkfwCI commented Mar 29, 2022

NotesTime
Note for Reviewer: E2E tests on remote server succeededTue, 29 Mar 2022 09:56:57 +0000

Generated by E2E-Test

@georgimld georgimld merged commit 9e1a6d7 into master Mar 29, 2022
@georgimld georgimld deleted the 1053-document-bug branch March 29, 2022 13:00
@daniel-arnauer daniel-arnauer restored the 1053-document-bug branch April 7, 2022 08:11
@daniel-arnauer daniel-arnauer deleted the 1053-document-bug branch April 7, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to grant authorizations to the "external readers" group
3 participants