Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1953 joi env validation #1963

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

1953 joi env validation #1963

wants to merge 23 commits into from
+1,774 −206

Conversation

galethil
Copy link
Collaborator

@galethil galethil commented Sep 6, 2024 •
edited
Loading

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

How to test

  1. Remove or change env vars for API to something non-valid

  2. Start TruBudget with development start script

  3. It should produce a correct error and don't start the app

  4. Modify env vars in api/src/envVarsSchema.ts

  5. Run npm run generate-env-vars-docs in api

  6. Markdown file in ./api/environment-variables.md should update

Closes #1953

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

Warnings
⚠️ No CHANGELOG added.
⚠️ There are new console logs in the API!

Generated by 🚫 dangerJS against 33b4a63

@galethil galethil changed the title WIP 1953 join env validation WIP 1953 joi env validation Sep 12, 2024
@galethil galethil changed the title WIP 1953 joi env validation 1953 joi env validation Sep 24, 2024
@galethil galethil marked this pull request as ready for review September 24, 2024 10:32
@galethil galethil changed the title 1953 joi env validation WIP 1953 joi env validation Sep 24, 2024
@galethil galethil changed the title WIP 1953 joi env validation 1953 joi env validation Sep 25, 2024
@galethil galethil changed the title 1953 joi env validation WIP 1953 joi env validation Sep 25, 2024
@openkfwCI
Copy link

openkfwCI commented Sep 25, 2024 •
edited
Loading

NotesTime
❕Note for Reviewer: E2E tests on pipeline 60481 on remote server startedTue, 01 Oct 2024 11:24:07 +0000

Generated by E2E-Test

@galethil galethil changed the title WIP 1953 joi env validation 1953 joi env validation Sep 25, 2024
SamuelPull
SamuelPull reviewed Sep 25, 2024
View reviewed changes
api/src/config.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelPull SamuelPull SamuelPull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Joi validation for env variables in all services
3 participants
@galethil @openkfwCI @SamuelPull