Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api:Create local custom rule warning when using absolute import #1995

Closed
wants to merge 2 commits into from

Conversation

galethil
Copy link
Collaborator

@galethil galethil commented Sep 26, 2024

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

Custom eslint rule warning for /api when using absolute import

How to test

  1. Run npm run lint or check code if eslint is setup in VSCode
  2. On absolute imports and packages not mentioned in package.json a warning is created

Closes #1994

@openkfwCI
Copy link

openkfwCI commented Sep 26, 2024

NotesTime
Note for Reviewer: E2E tests on pipeline 60490 on remote server succeededWed, 02 Oct 2024 09:14:34 +0000

Generated by E2E-Test

@MartinJurcoGlina
Copy link
Collaborator

I would do the same for the rest of the services as well to keep eslint rules consistent

@SamuelPull
Copy link
Collaborator

Nice work! I'm not sure if this is needed anymore, updating tsconfig disables relative imports.

@galethil galethil closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESlint warning about absolute imports
4 participants