ui: Bugfixes #571
Merged
ui: Bugfixes #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the excel sheet with information about the translation changes and what I implemented or rejected |
daniel-arnauer
force-pushed
the
small-bugfixes
branch
from
9cbad15 to
c7eb0e0
Compare
Generated by E2E-Test |
daniel-arnauer
force-pushed
the
small-bugfixes
branch
from
7c43f4f to
0409fc2
Compare
daniel-arnauer
commented
Oct 22, 2020
Comment on lines
190
to
193
| const mapDispatchToProps = dispatch => { | ||
| return { | ||
| fetchGroups: () => dispatch(fetchGroups(true)), | ||
| fetchGroups: () => dispatch(fetchGroups(false)), | ||
| fetchProjectPermissions: pId => dispatch(fetchProjectPermissions(pId, false)), |
There was a problem hiding this comment.
All fetch functions must not show a loading indicator to fix #555
daniel-arnauer
force-pushed
the
small-bugfixes
branch
from
647b762 to
6432d14
Compare
georgimld
approved these changes
Oct 22, 2020
daniel-arnauer
force-pushed
the
small-bugfixes
branch
3 times, most recently
from
15a0bdf to
5793ec7
Compare
added 4 commits
October 22, 2020 17:56
Fix double indicator in Confirmation Dialog[#555] Show loading indicator while uploading a document [#558] Added and fixed some translation [566] Fix stlye buf in GroupDialog [#557] Remove <;> at LoginPage Fix: To prevent a user from disabling himself, the button to disable the current logged-in user has been hidden. [#554]
Stezido
force-pushed
the
small-bugfixes
branch
from
5793ec7 to
b9ab1f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #554
Closes #566
Closes #555
Closes #558
Closes #557