-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove general logic that is inlined with route handlers #328
Milestone
Comments
16 tasks
zelima
added a commit
that referenced
this issue
May 3, 2017
- new logic layer for getting the datapackage - removed inlined logic from router - test for logic layer refs #328
zelima
added a commit
that referenced
this issue
May 3, 2017
zelima
added a commit
that referenced
this issue
May 4, 2017
zelima
added a commit
that referenced
this issue
May 8, 2017
zelima
added a commit
that referenced
this issue
May 8, 2017
zelima
added a commit
that referenced
this issue
May 8, 2017
zelima
added a commit
that referenced
this issue
May 8, 2017
[logic][xl]: * logic removed from auth controllers * inlined logic moved from package controllers to logic.py * models for search moved to logic - where it actually belongs refs #328
FIXED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is an undesirable pattern through all this code of having general logic inlined with route handlers. As the codebase grows, this gets unmanageable very quickly, and leads to duplication of logic and introduction of bugs. example, have a README util that gets called in the handler, rather than inlining the README processing logic: https://github.com/frictionlessdata/dpr-api/blob/master/app/site/controllers.py#L100
Acceptance criteria
Tasks
logic
folder and move site/logic.py up to there as/logic/__init__.py
+ move tests [no new test needed]logic.get_package
(prep for all other work we are about to do) [new tests or addition to existing logic test]The text was updated successfully, but these errors were encountered: