Fix 500 errors caused by templates #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuveyatsu
reviewed
May 10, 2017
app/logic/__init__.py
Outdated
|
|
||
| def validate_for_template(descriptor): | ||
| ''' | ||
| Cheks if descriptor fields have expected type for template Eg: |
There was a problem hiding this comment.
small typo: "Checks ..."
There was a problem hiding this comment.
Probably it's better to rewrite:
"This function validates field types in the descriptor, e.g., licenses property should be a list."
anuveyatsu
reviewed
May 10, 2017
| def test_validate_for_jinja_modifies_descriptor_if_licenses_is_dict(self): | ||
| self.descriptor['licenses'] = {'url': 'test/url', 'type': 'Test'} | ||
| descriptor = validate_for_template(self.descriptor) | ||
| self.assertEqual(descriptor['license'], 'Test') |
There was a problem hiding this comment.
so licenses (plural) then it is a list, and if license singular then it is a string?
anuveyatsu
suggested changes
May 10, 2017
anuveyatsu
approved these changes
May 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #355