Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flex-basis with percentage not working #1300

Merged
merged 10 commits into from
Apr 15, 2022
Merged

fix: flex-basis with percentage not working #1300

merged 10 commits into from
Apr 15, 2022

Conversation

temper357
Copy link
Contributor

@temper357 temper357 commented Apr 6, 2022 •
edited
Loading

Closes #1277
Closes #1278

  • 修复 flex-basis 未支持百分比类型。
  • 修复根据 flex-basis 计算 flex-grow/flex-shrink 时未考虑 min-width(height)/max-width(height)。
  • 修复 flex-grow 与 max-width(height) 同时存在时 justify-content 与 margin auto 对齐失效。

@temper357 temper357 changed the title [WIP] fix: flex-basis with percentage not working fix: flex-basis with percentage not working Apr 7, 2022
@temper357 temper357 requested review from yuanyan, andycall, wssgcg1213 and answershuto and removed request for yuanyan and andycall April 7, 2022 08:01
@answershuto answershuto merged commit 1091f79 into main Apr 15, 2022
@answershuto answershuto deleted the fix/flex-basis-percentage branch April 15, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@answershuto answershuto answershuto approved these changes

@wssgcg1213 wssgcg1213 wssgcg1213 approved these changes

@yuanyan yuanyan Awaiting requested review from yuanyan

@andycall andycall Awaiting requested review from andycall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@temper357 @wssgcg1213 @answershuto