Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: script async can be delayed, error event trigger without exception #1358

Merged
merged 4 commits into from
Apr 26, 2022
Merged

fix: script async can be delayed, error event trigger without exception #1358

merged 4 commits into from
Apr 26, 2022

Conversation

wssgcg1213
Copy link
Member

修复 script 标签在使用时的异常

  1. 修复 script 标签加载异常抛出 error 事件处理导致崩溃的问题
  2. 修复 script 标签标记为 async 执行异常的问题, 增加了测试用例

@wssgcg1213 wssgcg1213 merged commit ce88942 into main Apr 26, 2022
@wssgcg1213 wssgcg1213 deleted the fix/async-script branch April 26, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanyan yuanyan yuanyan left review comments

@temper357 temper357 temper357 approved these changes

@answershuto answershuto answershuto approved these changes

@andycall andycall Awaiting requested review from andycall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wssgcg1213 @yuanyan @temper357 @answershuto