Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type definitions #125

Merged
merged 6 commits into from
May 22, 2020
Merged

Fix type definitions #125

merged 6 commits into from
May 22, 2020

Conversation

deathaxe
Copy link
Contributor

@deathaxe deathaxe commented May 17, 2020

Description (e.g. "Related to ...", etc.)

This commit

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

pygls/types.py Outdated Show resolved Hide resolved
pygls/types.py Outdated Show resolved Hide resolved
@danixeee danixeee added bug Something isn't working enhancement New feature or request labels May 20, 2020
@danixeee danixeee self-requested a review May 20, 2020 10:50
Copy link
Contributor

@danixeee danixeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perrinjerome thanks for the help!

According to the specs, there are some new base types:

So, HoverParams should extend WorkDoneProgressParams instead of adding a workDoneToken field. You do not have to add all of these types in this PR, maybe you can just remove self.workDoneToken = work_done_token from HoverParams and we can merge it.

@danixeee danixeee merged commit e56b4be into openlawlibrary:master May 22, 2020
@deathaxe deathaxe deleted the pr/fix-types branch May 27, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In SymbolKindAbstract value_set should be a list type based on the spec.
3 participants