-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebSocket server #129
Add WebSocket server #129
Conversation
986d9d4
to
de2bcaf
Compare
I think PR is at the point when it's ready for review/discussion.
Any feedback appreachiated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatejKastak Sorry for the delayed response. We have removed support for python 3.5, so that's not a problem anymore. Take a look at the inline comments and let me know what do you think about how we should solve them.
4bfdaa9
to
6068321
Compare
@MatejKastak I just pushed minor updates, thanks and sorry for waiting this long. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine with Monaco client.
Description
Implementation of WebSocket server. This PR allows users to start the WebSocket server on a given
host
andport
that will "wrap" the LSP protocol. The interface is the same as otherSERVER.start_*
methods.The main use case is to create convenient interface to interact with editors that are embedded in internet browsers (for example Monaco LSP-client), this could potentially allow for broader adoption.
Related to #85
Code review checklist (for code reviewer to complete)