Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn coroutine to async def #136

Merged
merged 2 commits into from
Sep 29, 2020

Conversation

danixeee
Copy link
Contributor

Description (e.g. "Related to ...", etc.)

Turn coroutine to async def to resolve deprecation warning:

"@coroutine" decorator is deprecated since Python 3.8, use "async def" instead.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@danixeee danixeee added the refactor Internal code and/or logic changes label Sep 29, 2020
@danixeee danixeee self-assigned this Sep 29, 2020
@renatav renatav merged commit a80c1e7 into master Sep 29, 2020
@renatav renatav deleted the danixeee/fix-coroutine-deprecation-warning branch September 29, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Internal code and/or logic changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants