Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update json-example #175

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Update json-example #175

merged 1 commit into from
Apr 21, 2021

Conversation

danixeee
Copy link
Contributor

Description (e.g. "Related to ...", etc.)

  • updated npm packages
  • use eslint instead of deprecated tslint
  • re-formatted extension.ts

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@danixeee danixeee added the refactor Internal code and/or logic changes label Apr 21, 2021
@danixeee danixeee requested a review from renatav April 21, 2021 10:53
@danixeee danixeee mentioned this pull request Apr 21, 2021
Closed
@danixeee danixeee force-pushed the danixeee/json-example-npm-updates branch from 5bf1402 to f10b1b5 Compare April 21, 2021 11:15
renatav
renatav approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@renatav renatav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@danixeee danixeee merged commit 78eef26 into master Apr 21, 2021
@danixeee danixeee deleted the danixeee/json-example-npm-updates branch April 21, 2021 11:59
@danixeee danixeee mentioned this pull request Apr 26, 2021
Closed
brettcannon pushed a commit to brettcannon/pygls that referenced this pull request Apr 30, 2021
@danixeee @brettcannon
Update npm packages; Use eslint (openlawlibrary#175)
50ea1a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatav renatav renatav approved these changes

Assignees
No one assigned
Labels
refactor Internal code and/or logic changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danixeee @renatav