-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest lsprotocol
v2024.0.0a2
#487
Conversation
ded5c7f
to
8d4dcaf
Compare
8d4dcaf
to
210c7e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for this!
Would it be possible to get a before and after list of the names that have changed? Something we'd be able to put in a guide similar to this one
@@ -1,6 +1,6 @@ | |||
[tool.poetry] | |||
name = "pygls" | |||
version = "1.3.1" | |||
version = "2.0.0a1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tombh do we edit the version number manually, or does the release automation do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We edit it manually. I'm surprised I hadn't made a RELEASING.md
doc, so I've made a PR that outlines the release process: #488
@alcarney I will provide a table to go from old to new types. |
Here is a table of types for migration: Migration TableFor:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks!
I don’t have merge rights, please merge when possible. |
Description (e.g. "Related to ...", etc.)
This PR updates
pygls
to latest LSP 3.18 spec and its implementationlsprotocol
2024.0.0a2:Code review checklist (for code reviewer to complete)
Automated linters
You can run the lints that are run on CI locally with: