Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated code #492

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

alcarney
Copy link
Collaborator

Description (e.g. "Related to ...", etc.)

This PR removes the code we've previously deprecated (the old workspace and position encoding methods). All removed methods have an alternative which has been documented in the draft migration guide.

I have also started migrating some of my projects and have added them to the list of known migrations.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

Automated linters

You can run the lints that are run on CI locally with:

poetry install --all-extras --with dev
poetry run poe lint

@alcarney alcarney force-pushed the remove-deprecations branch 2 times, most recently from 5cb1f2b to ceffec5 Compare August 24, 2024 09:43
@alcarney alcarney force-pushed the remove-deprecations branch from ceffec5 to 97e982e Compare August 24, 2024 09:45
@alcarney alcarney requested a review from tombh August 24, 2024 09:50
@alcarney
Copy link
Collaborator Author

Thanks!

Can you think of anything else that should go into this initial pass at v2? Or shall we make a pre-release to PyPi so people can start trying it out?

@alcarney alcarney merged commit 6d59a77 into openlawlibrary:main Aug 24, 2024
16 checks passed
@alcarney alcarney deleted the remove-deprecations branch August 24, 2024 17:39
@tombh
Copy link
Collaborator

tombh commented Aug 24, 2024

I can't think of anything right now. We can always make more pre-releases as we need.

Would you like to have a go at making the release using the new doc in #488? I'm happy to do it too if you'd prefer.

@alcarney
Copy link
Collaborator Author

Sure, I'll give it a go! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants