Can not join the dao with a 0x0 address #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fforbeck
force-pushed
the
gh-282
branch
2 times, most recently
from
66b3e3c to
51a92d1
Compare
jdville03
previously approved these changes
May 17, 2021
Co-authored-by: Jarrel deLottinville <jarrel.delottinville@gmail.com>
jdville03
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should not be possible to onboard a member using a 0x0 address.
Updated the deployment scripts to include the
owneraddress in thefromargument of the call, so it can be verified if the call was actually made by a member or not.In addition to that, it updates the deployment script
2_deploy_contracts.jsto include theowneraddress in the dao creation -which is loaded from an environment variableDAO_OWNER_ADDRif the target network is Rinkeby. Othewise, for test and ganache deployments it uses the truffle accounts[0] as theDAO_OWNER_ADDR.Fixes #282