Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple cesium resource control #235

Merged
merged 2 commits into from
Sep 3, 2015

Conversation

gberaudo
Copy link
Member

This PR allows blocking Cesium rendering which is useful to save
resources. When no interaction is expected on the map, the application
can choose to block Cesium loop. Later on it may be unblocked.

@gberaudo
Copy link
Member Author

Related issues in Cesium:
CesiumGS/cesium#2655
CesiumGS/cesium#1865

@gberaudo
Copy link
Member Author

gberaudo commented Sep 3, 2015

Any review?

@gberaudo gberaudo force-pushed the simple_cesium_resource_control branch from 6945867 to f0bbb32 Compare September 3, 2015 13:42
@@ -8,6 +8,8 @@
primitive collection may be retrieved with the `getRootPrimitive()` method.

* Changes
* Allow blocking Cesium rendering to save resources using
`olcs.OLCesium#blockCesiumRendering(true)`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be olcs.OLCesium#setBlockCesiumRendering(true)

@fredj
Copy link
Member

fredj commented Sep 3, 2015

+1, thanks

This commit allows blocking Cesium rendering which is useful to save
resources. When no interaction is expected on the map, the application
can choose to block Cesium loop. Later on it may be unblocked.
@gberaudo gberaudo force-pushed the simple_cesium_resource_control branch from f0bbb32 to a50b5da Compare September 3, 2015 13:53
gberaudo added a commit that referenced this pull request Sep 3, 2015
@gberaudo gberaudo merged commit c2db342 into openlayers:master Sep 3, 2015
@gberaudo
Copy link
Member Author

gberaudo commented Sep 3, 2015

Thank you for the review @fredj.

@gberaudo gberaudo deleted the simple_cesium_resource_control branch September 3, 2015 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants