Compile OL3-Cesium together with OL3 #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OL3-Cesium used to be compiled against OL3 externs. This was unnatural for a Closure project and had shortcomings: - a custom closure compiler was required; - we were restricted to OL3 @api symbols; - OL3 externs were sometimes buggy; - the goog library was included twice; ... This change bundles the OL3 code together with OL3-Cesium, which is equivalent to what does Ngeo.
| @@ -1,4 +1,4 @@ | |||
| { | |||
gberaudo
force-pushed
the
compile_with_ol3
branch
from
260f2d4 to
b924fbe
Compare
Exports are read both from OL3 and from OL3-Cesium.
gberaudo
force-pushed
the
compile_with_ol3
branch
from
b924fbe to
15575a0
Compare
|
@fredj, I removed the file and instead put instructions in the |
|
+1 |
|
Thanks for the review @fredj. |
gberaudo
added a commit
that referenced
this pull request
Nov 19, 2015
Compile OL3-Cesium together with OL3
gberaudo
added a commit
to geoadmin/mf-geoadmin3
that referenced
this pull request
Nov 19, 2015
Required following openlayers/ol-cesium#289. As a side note, the total size of app + ol3 + ol3-cesium is now around 15K lighter (before gzip).
gberaudo
added a commit
to geoadmin/mf-geoadmin3
that referenced
this pull request
Nov 27, 2015
Required following openlayers/ol-cesium#289. Changes: - Rename the 'ga' angular module to 'geoadmin' to prevent conflict with a 'ga' minified symbol from the OL3/OL3-Cesium compilation; - Rename 'ga.GaRasterSynchronizer' to 'olcs.GaRasterSynchronizer' to prevent similar conflict; - Rename production Cesium.js to Cesium.min.js to help spot unminified/minified mismatch and added an angular 'buildMode' config which is now tested to know which Cesium version to load (debug or prod); - Remove 'ol' target. OL3 is now checkouted in 'ol3-cesium/ol3'; - Compile OL3 and OL3-Cesium together. As a side note, the total size of app + ol3 + ol3-cesium is now around 15K lighter (before gzip).
gberaudo
added a commit
to geoadmin/mf-geoadmin3
that referenced
this pull request
Nov 30, 2015
Required following openlayers/ol-cesium#289. Changes: - Rename the 'ga' angular module to 'geoadmin' to prevent conflict with a 'ga' minified symbol from the OL3/OL3-Cesium compilation; - Rename 'ga.GaRasterSynchronizer' to 'olcs.GaRasterSynchronizer' to prevent similar conflict; - Rename production Cesium.js to Cesium.min.js to help spot unminified/minified mismatch and added an angular 'buildMode' config which is now tested to know which Cesium version to load (debug or prod); - Remove 'ol' target. OL3 is now checkouted in 'ol3-cesium/ol3'; - Compile OL3 and OL3-Cesium together. As a side note, the total size of app + ol3 + ol3-cesium is now around 15K lighter (before gzip).
gberaudo
added a commit
to geoadmin/mf-geoadmin3
that referenced
this pull request
Dec 1, 2015
Required following openlayers/ol-cesium#289. Changes: - Rename the 'ga' angular module to 'geoadmin' to prevent conflict with a 'ga' minified symbol from the OL3/OL3-Cesium compilation; - Rename 'ga.GaRasterSynchronizer' to 'olcs.GaRasterSynchronizer' to prevent similar conflict; - Rename production Cesium.js to Cesium.min.js to help spot unminified/minified mismatch and added an angular 'buildMode' config which is now tested to know which Cesium version to load (debug or prod); - Remove 'ol' target. OL3 is now checkouted in 'ol3-cesium/ol3'; - Compile OL3 and OL3-Cesium together. As a side note, the total size of app + ol3 + ol3-cesium is now around 15K lighter (before gzip).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OL3-Cesium used to be compiled against OL3 externs.
This was unnatural for a Closure project and had shortcomings:
...
This change bundles the OL3 code together with OL3-Cesium, which is already what we do in Ngeo.
This will allow adding client side raster reprojection in the future.