Skip to content

Conversation

@szekerest
Copy link
Contributor

No description provided.

@ahocevar
Copy link
Member

Thanks! Can you confirm that tests still pass with this in major browsers, including IE8?

One improvement suggestion: It would even be nicer to only detect this once, e.g.

OpenLayers.Format.XML.useActiveX = (function() {
    return (Object.getOwnPropertyDescriptor &&
            Object.getOwnPropertyDescriptor(window, "ActiveXObject")) ||
            ("ActiveXObject" in window);
})();

Or maybe even without the anonymous function.

@szekerest
Copy link
Contributor Author

Tested the approach in Chrome, Firefox and IE11.
Need to find a PC which runs IE8.

@ahocevar
Copy link
Member

Let me see if I can find that old WinXP VM of mine...

@ahocevar
Copy link
Member

Works fine in IE8. @szekerest, are you able to implement the improvement I suggested above, and also use OpenLayers.Format.XML.useActiveX in OpenLayers.Format.WPSExecute#write(), like @bkiselka did?

@szekerest
Copy link
Contributor Author

@ahocevar Modified the pull

@ahocevar
Copy link
Member

Thanks for the continued effort on this @szekerest. Can you please submit a CLA so we can merge this?

@szekerest
Copy link
Contributor Author

@ahocevar Signed

ahocevar referenced this pull request in openlayers/cla Mar 25, 2015
Thanks @szekerest for openlayers/openlayers#1439 and any other contributions you can make.
ahocevar added a commit that referenced this pull request Mar 25, 2015
Fix detection of activex support to work in IE11
@ahocevar ahocevar merged commit 4455446 into openlayers:master Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants