-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Books plugin documentation update #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @S-Haime--this is really good! I especially like the contextual detail you provide. Things like this show you are thinking through the questions people will have, which of course you are, but just wanted to say so explicitly because it is great:
Make sure that the filename of the file uploaded is consistent and correct. Whilst Janeway will change the filename to the title internally, depending on the application used to open the document after download, the original filename might still be visible. Google Chrome is an example of an application that might still display the original filename in its reader toolbar, as displayed in the image below.
I added a few comments below.
In terms of building the documentation, I don't think we have a setup for RST on plugins yet. We'd have to configure that if we wanted it to show up on readthedocs.io. I can do that and help you with it @S-Haime so if that's what we want to do. Thoughts @ajrbyers?
Another option: Since we are phasing out RST, one easy short-term solution that keeps us from having to add more RST configuration is to just put this in a markdown file, something like USER_GUIDE.md
at the top level of the repository. With an images
folder replacing nstatic
and a link from the main README.md
file so people can read the docs on GitHub. Basic but functional. What do you think?
docs/Books.rst
Outdated
- No | ||
|
||
.. [#] Using a character encoding other than UTF-8 can cause bugs during imports or updates. `(What is character encoding?) <https://www.w3.org/International/questions/qa-what-is-encoding>`_. These apps save .csvs with UTF-8 by default: OpenRefine, LibreOffice, Google Sheets, and Apple Numbers. However! If you use Microsoft Excel, keep in mind some versions don’t automatically create .csv files with UTF-8 character encoding. This may cause punctuation and special characters to be garbled on import. So, when saving, look for the ‘.csv (UTF-8)’ option in the drop-down box. | ||
.. [#] Required due to a bug - we aim to fix this in the near future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a missing reference to this note?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed now in .md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These images are great in terms of the content they cover and their frequency.
But for the long term I'm hoping we can take narrower versions of them, so they fit in a narrower container on our future docs site. We currently let the text and images run very wide in our documentation, but this isn't best practice and our future documentation site will hopefully use something more in the range of <580px for prose and <960px for content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I haven't addressed any of the images, as I imagine we'll want to look at this as part of the website building.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. As @joemull mentioned we are phasing rst out so it may be worth converting this to md. For this file, as there are no toctrees it should be relatively simple.
Thanks @ajrbyers. @S-Haime I think that means we should do this:
Let me know if I can help. I will go ahead and give this PR the status of Changes Requested. |
The .rst file can be retired at some point now :) |
Documentation for the books plugin.
Adding @joemull as a reviewer since you volunteered and @ajrbyers as this is your plugin.
Minor points: