Make sure country can still be looked up on the Supporter record #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephDriver
requested review from
ajrbyers
and removed request for
StephDriver
ajrbyers
approved these changes
Oct 3, 2024
mauromsl
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preserves the
Supporter.countryinterface by adding a method where the field used to be. The field was removed in favor of theBand.countryfield, which is where country usually needs to be accessed for calculating fees and things.With this fix, not so much is required to change on the supporter list page on Hourglass to get it looking good. So this contributes to closing openlibhums/hourglass#397.