Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend Us templates #403

Merged
merged 7 commits into from
Oct 31, 2024
Merged

Recommend Us templates #403

merged 7 commits into from
Oct 31, 2024

Conversation

joemull
Copy link
Member

@joemull joemull commented Oct 25, 2024

See openlibhums/consortial_billing#81 for notes and the associated views and urls.

Helps close openlibhums/consortial_billing#74.

@joemull joemull changed the title Recommend Us page Recommend Us templates Oct 25, 2024
@joemull joemull force-pushed the cb-74-recommend-us branch from 45e3e2a to 0b55720 Compare October 28, 2024 18:45
@joemull joemull marked this pull request as ready for review October 28, 2024 18:56
@joemull joemull requested a review from ajrbyers October 28, 2024 18:57
Copy link
Member

@ajrbyers ajrbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this works well. I did notice that there was a lack of spacing when there is more than one article returned by a search though.

Screenshot 2024-10-29 at 11 10 50

@ajrbyers ajrbyers assigned joemull and unassigned ajrbyers Oct 29, 2024
@joemull joemull requested a review from ajrbyers October 30, 2024 14:44
@joemull joemull assigned ajrbyers and unassigned joemull Oct 30, 2024
@joemull joemull force-pushed the cb-74-recommend-us branch from 97be9e3 to 2bf6c26 Compare October 30, 2024 14:48
@ajrbyers ajrbyers merged commit bcb0a84 into main Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As an author I want to generate an email to my librarian
3 participants