Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures that file download headers have clean filenames #4441

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Ensures that file download headers have clean filenames #4441

wants to merge 1 commit into from

Conversation

ajrbyers
Copy link
Member

@ajrbyers ajrbyers commented Oct 2, 2024 •
edited
Loading

Closes #4440

A PR to protect against importing of content with these characters is available: openlibhums/imports#101

@ajrbyers ajrbyers mentioned this pull request Oct 2, 2024
Open
@joemull
Copy link
Member

joemull commented Oct 17, 2024

@ajrbyers is this ready for review?

@ajrbyers ajrbyers marked this pull request as draft October 17, 2024 10:06
@ajrbyers
Copy link
Member Author

@ajrbyers is this ready for review?

@ajrbyers is this ready for review?

No - I’ve spotted a similar issue with a different character and want to test if this fixes that issue also.

@ajrbyers
Copy link
Member Author

Converted to draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reader cannot download a galley file
2 participants
@ajrbyers @joemull