Update MCNP data library conversion scripts #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom MCNP6.2 distrbution.
amandalund
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our MCNP library conversion scripts mentioned using the
mcplib84photoatomic data library, which actually doesn't work with OpenMC because it doesn't contain photoelectric subshell cross sections. Only the newereprdata12oreprdata14libraries are valid, so those are explicitly called out in the script now. Because they exist in a different directory in MCNP's distribution, there's now just a separate optional argument for specifying the path to the photon library.Also, I learned that in the MCNP 6.2 distribution, there are a few data files that have been updated, but both old/new ones are present, so it's not sufficient to just glob for all files and convert. I've added some logic that selectively removes older ACE files in favor of the newer ones. This affects H1 and three thermal scattering materials (SiO2, UO2, and ZrH).
Once this is merged, I'll update the corresponding converted MCNP libraries on openmc.org.