Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Werror=reorder in random ray #2997

Closed
aprilnovak opened this issue May 11, 2024 · 0 comments · Fixed by #2998
Closed

Fix -Werror=reorder in random ray #2997

aprilnovak opened this issue May 11, 2024 · 0 comments · Fixed by #2998

Comments

@aprilnovak
Copy link
Contributor

Description

MOOSE is compiled with -Werror=reorder, which checks for consistency in the ordering of variables in class definitions vs. when they are initialized in a constructor. Members are initialized in the order they are defined in the class, not the constructor, and using a different ordering can result in errors.

Alternatives

The easiest solution is to patch OpenMC, rather than change the compile flags in MOOSE.

Compatibility

No anticipated change.

aprilnovak added a commit to aprilnovak/openmc that referenced this issue May 11, 2024
aprilnovak added a commit to aprilnovak/openmc that referenced this issue May 11, 2024
aprilnovak added a commit to aprilnovak/openmc that referenced this issue May 11, 2024
paulromano added a commit that referenced this issue May 14, 2024
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
church89 pushed a commit to openmsr/openmc that referenced this issue Jul 18, 2024
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant