Review by PullRequest, Inc. - Part 1 #1455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PullRequest-Agent
requested review from
amandalund,
drewejohnson,
icmeyer,
nelsonag,
paulromano,
pshriwise and
shikhar413
as code owners
| bottom.boundary_type = 'vacuum' | ||
|
|
||
| # Instantiate Cells | ||
| cell1 = openmc.Cell(cell_id=1, name='Cell 1') |
There was a problem hiding this comment.
Just want to confirm, that it's expected that Cell 1 here is upper-cased C whereas the other cells are lower-cased c.
paulromano
added a commit
to paulromano/openmc
that referenced
this pull request
Jan 27, 2020
paulromano
added a commit
to paulromano/openmc
that referenced
this pull request
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been generated for a professional code review sponsored by UKAEA.
We have split up the review into 5 parts with different files each to prevent the individual pull requests from getting too large or having too many comments for GitHub to render. As a part of this it also means there is only 1/5th of the code on this branch which is why the tests are failing.
NOTE: This pull request and its contents are a recreation of one submitted a few weeks ago which had to be taken down due limitations which have since been resolved.