Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ParticleList class for manipulating a list of source particles #3148

Merged

Conversation

zoeprieto
Copy link
Contributor

@zoeprieto zoeprieto commented Sep 27, 2024

Description

This is a preliminary solution to the issue #3147 for reading, filtering, and generating new surface source files. It is a first approach to post-processing of surface sources.
A SourceParticles class is created as a SourceParticle list for handling source particles in the Python API.

Fixes #3147

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@paulromano paulromano changed the title Surface source postprocessing Introduce ParticleList class for manipulating a list of source particles Oct 4, 2024
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zoeprieto I did a bit of refactoring on this branch. Let me know what you think of the changes and if you are happy, please go ahead and add some tests and then we can get this merged in. Thanks!

@zoeprieto
Copy link
Contributor Author

Thank you @paulromano for the changes, now it is definitely clearer. I added some tests as a first proposal. Let me know if you are ok with where I put them and if any extra tests should be added.

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set now; thanks for the tests!

@paulromano paulromano enabled auto-merge (squash) October 5, 2024 04:03
@paulromano paulromano merged commit 2450eef into openmc-dev:develop Oct 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the capability to read, filter and generate a new surface source file
2 participants