-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ParticleList class for manipulating a list of source particles #3148
Introduce ParticleList class for manipulating a list of source particles #3148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zoeprieto I did a bit of refactoring on this branch. Let me know what you think of the changes and if you are happy, please go ahead and add some tests and then we can get this merged in. Thanks!
Thank you @paulromano for the changes, now it is definitely clearer. I added some tests as a first proposal. Let me know if you are ok with where I put them and if any extra tests should be added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All set now; thanks for the tests!
Description
This is a preliminary solution to the issue #3147 for reading, filtering, and generating new surface source files. It is a first approach to post-processing of surface sources.
A
SourceParticles
class is created as aSourceParticle
list for handling source particles in the Python API.Fixes #3147
Checklist