-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulation of decay photons through the D1S method #3235
Open
paulromano
wants to merge
30
commits into
openmc-dev:develop
Choose a base branch
from
paulromano:decay-photon-d1s
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,296
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 20, 2024
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new capability to carry out direct 1-step (D1S) shutdown dose rate calculations, which are based on a coupled neutron–photon transport calculation where the results are scaled by "time correction factors". For those interested in more of the details, I'd recommend reading through a recent paper on the topic, such as that by Sauvan et al. The implementation here has a few pieces that come together in a relatively user-friendly workflow, consisting of functions in a new
openmc.deplete.d1s
module. How it works is:settings.use_decay_photons = True
. Internally, this will cause OpenMC to read decay source information from a chain file and use it to construct reaction products representing decay photons.d1s.prepare_tallies
function modifies tallies by adding aParentNuclideFilter
, a new filter introduced here that allows us to filter photon tallies by which radionuclide produced the photon in the first place. This is necessary for correctly applying the time correction factors, which are different for each radionuclide.d1s.time_correction_factors
function, which takes an irradiation schedule like any other depletion calculation (timesteps + source rates).d1s.apply_time_correction
function takes any tally with aParentNuclideFilter
and applies the time correction factors to get properly normalized results, which it returns in a new tally object.Altogether, this looks like the following in code:
V&V
I presented some results using this implementation at TOFE earlier this year. On the FNG dose rate benchmark from SINBAD, we get the following results with D1S relative to the R2S method:
Remaining tasks
Checklist