Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the LegendreFilter filter to be used in photon tallies for orders greater than P0. #3245

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

nelsonag
Copy link
Contributor

@nelsonag nelsonag commented Jan 7, 2025

Description

As noted in #3243 , the LegendreFilter does not work for photon scores. The change was quite simple as a local variable, mu, was used for the change-in-angle during scattering kinematics and never stored on p.mu. This PR corrects this. Results can be seen in the attached .zip which contains the model.xml, the original tallies.out, and a new tallies.out created from the code in this PR. Note the model and original tallies.out is the same as in #3242.
photon_mu.zip

Note, this PR is baselined off of #3242 and that should be merged first.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

…uly 0 on 64-bit computers instead of ~1e-219. This is needed as photon scores (e.g., photoelectric) below thresholds had non-zero values.
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nelsonag!

@paulromano paulromano enabled auto-merge (squash) January 14, 2025 13:52
@paulromano paulromano merged commit 549cc09 into openmc-dev:develop Jan 14, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants