Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring only exact "vacuum" assignment is detected as vacuum #3264

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

bam241
Copy link
Contributor

@bam241 bam241 commented Jan 15, 2025

Description

This is a follow up on svalinn/DAGMC#805

This ensures that a assignment named "not_a_vacuum" is not flagged as vacuum and therefore is not assigned with vacuum boundary condition.

Fixes # (issue)
This is related to #3218

I also had to implement that a different way than initially expected.
I first thought about leveraging the #3056 PR recently merged to do this kind of test.
But, vacuum detection is perform (in the DAGMC workflow within openMC) before applying materials assignment (therefore before overriding)

This is why I implemented this by making temporary copy of the dagmc.hm5 and modifying them. (Not that seing how simple this is we could potentially provide a method that allows to do that within dagmc.py ?)

I trying and failed to design this test as a fixture, I don't know why it failed it never recognised the returned model as a openmc.Model but as a function... (@pshriwise if you have any insight on this ?)

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

This works is sponsored by Proxima Fusion

@bam241 bam241 requested a review from pshriwise as a code owner January 15, 2025 09:58
@bam241 bam241 changed the title Vaccum detction test Ensuring only exact "vacuum" assignment is detected as vacuum Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant