-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added terminal output showing compile options selected #3291
added terminal output showing compile options selected #3291
Conversation
For CI, why not just check the CMakeCache file? |
I guess that would also work in some cases, but I think having terminal output in the CI logs is a bit more convenient than the connecting to the CI runner and opening a file. The logs are also available for longer than the ability to connect to a runner and access files which means reviewers can see from the logs if something was built correctly sometime after the PR. |
Oh I see, you meant for debugging, not scripting within CI. I was confused. looks good to me then! |
Yes that name of the CI task is also super useful, I believe it is made from the CI matrix settings here openmc/.github/workflows/ci.yml Lines 68 to 71 in 6e0f156
This is not quite the same compile arguments that OpenMC CMakelists file obtains. Some of these we don't vary in the CI. for example the CI matrix does not include In addition to the use in CI it is also useful (to myself at least) when locally compiling to know what is enabled and what is not. This PR puts that information into the terminal so the user is reminded of the default values that are used or helping if the user mistypes an arg name they can then check that it is compiled as desired. |
sorry just saw Gridley had already replied. I see this is approved, thanks for that. Let us leave this open for a day in case there are any objections If not I am can to merge this one in tomorrow |
I'm sure you already know, but from your build directory you can also see these options from |
I guess if people have sudo permissions to install cmake-curses-gui and then yes I think the CI usage (original motivation) still stands. |
This will also help with the pip install using scikit core which by builds in a tmp dir and deletes the folder afterwards. |
Co-authored-by: Jon Shimwell <jon@proximafusion.com>
Description
This PR adds a small amount of information to the user so that they can see which options were used to compile openmc
this is useful for CI when building different options
currently cmake .. outputs
This PR would add a little info to the start and the cmake .. terminal output would look like this
Fixes # (issue)
Checklist