Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 2D meshes, energy function filter #64

Merged
merged 4 commits into from
Oct 25, 2021

Conversation

paulromano
Copy link
Contributor

This PR adds support for plotting tally results when a mesh filter with a 2D mesh is used. I've also fixed a bug whereby a tally with an EnergyFunctionFilter would cause an exception to be raised.

@paulromano paulromano requested a review from pshriwise October 20, 2021 17:18
@paulromano paulromano force-pushed the mesh2d-fix branch 2 times, most recently from 846c8bb to 3dd4818 Compare October 20, 2021 19:18
Copy link
Collaborator

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the added capability @paulromano! An extra thank you for updating the CI along the way. 🙌🏻

@pshriwise pshriwise merged commit 7c488a0 into openmc-dev:develop Oct 25, 2021
@paulromano paulromano deleted the mesh2d-fix branch October 28, 2021 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants