-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Description
Current state
At the moment, the theme (light/dark) follows the system settings. We also only support the default sap_horizon
(sap_horizon_dark
) theme.
Improvements
-
In our reviews people expressed the wish to manually set the theme (@reshnm)
-
Compatibility and nice integration with openMFP
-
When we integrate with Hyperspace portal, we will need to support the following themes:
- Morning Horizon
sap_horizon
- Evening Horizon
sap_horizon_dark
- High Contrast Black
sap_horizon_hcb
- High Contrast White
sap_horizon_hcw
These themes are set via URL parameters, e.g. http://localhost:5173/?sap-theme=sap_horizon_hcb – does not work at the moment but this is how it should behave:
- Morning Horizon
Implementation Details
At the moment, we read the preferred colour theme (OS setting) and set the theme to sap_horizon
or sap_horizon_dark
(component <DarkModeSystemSwitcher>
).
Suggestion: We should give preference to the URL parameter sap-theme
and only fall back to the current logic (OS settings) when it’s missing.
Could also think of providing a switch somewhere (where?) to set the theme which will then in turn set the corresponding URL parameter.