-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Adding support for Kustomize projects #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,151 @@ | |||
@actions/core | |||
MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated every time during packaging phase by the npm. Contents depends on used npm packages. This is the same case as in existing helm-chart packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,151 @@ | |||
@actions/core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated every time during packaging phase by the npm. Contents depends on used npm packages. This is the same case as in existing helm-chart packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,170 @@ | |||
@actions/core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated every time during packaging phase by the npm. Contents depends on used npm packages. This is the same case as in existing helm-chart packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kustomize-listing.yaml
Outdated
@@ -0,0 +1,30 @@ | |||
# Kustomize Listing Document which contains all found Kustomize projects with kustomization.yaml or kustomization.yml | |||
|
|||
test_kustomize_helloWorld: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wchomik i don't think its good to have a pre-filled file committed & pushed. Pls remove yaml content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see content committed. Please remove yaml content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the contents of the listing file but forgot to add it to the .gitignore so it got commited back in CI. Fixed
During the build process for our TypeScript-based GitHub Actions, a Currently, the repository is managed under Apache-2.0 via REUSE. However, because REUSE tracks licensing on a per-file basis, it does not easily accommodate dynamically generated artifacts that include multiple third-party licenses. The result is that each dependancy (and all its files) may not be properly tracked or declared in a way that maintains REUSE compliance. Addressing this properly would likely require:
To avoid blocking the current PR, I recommend creating a separate backlog issue dedicated to defining a reliable and automated approach for REUSE compliance of compiled artifacts. |
kustomize-listing.yaml
Outdated
@@ -0,0 +1,30 @@ | |||
# Kustomize Listing Document which contains all found Kustomize projects with kustomization.yaml or kustomization.yml | |||
|
|||
test_kustomize_helloWorld: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see content committed. Please remove yaml content.
No description provided.