rename AccessRequest secret #131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changes the name of the secret created by the AccessRequest. It was just the AccessRequest's name before, which is fine when coming from the AccessRequest and looking for the secret, but confusing when just listing secrets.
This change renames the secret to
<access-request-name>.kubeconfig(similar to how the ClusterProviderkinddoes it). If that exceeds the character limit, parts of the AccessRequest's name will be cut off and replaced by a hash while the.kubeconfigsuffix will be preserved.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
This change will 'leak' secrets with the old name from existing AccessRequests, as long as the AccessRequest exists. Since the old secret has an owner reference, it will be removed when the AccessRequest is deleted.
Release note: