feat: wait with cluster deletion until foreign finalizers are removed #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diaphteiros
requested review from
ValentinGerlach,
maximiliantech,
reshnm and
robertgraeff
reshnm
approved these changes
Oct 16, 2025
Diaphteiros
force-pushed
the
fix-cluster-deletion
branch
from
a644a2b to
b0455a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes the ClusterProvider wait with the shoot deletion until all 'foreign' finalizers have been removed from the
Cluster.Which issue(s) this PR fixes:
Part of openmcp-project/backlog#313.
Special notes for your reviewer:
Release note: