fix: preserve metadata fields #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diaphteiros
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Kubernetes was not allowing to set any
metadatafield in theShootTemplate:strict decoding error: unknown field "spec.shootTemplate.metadata.labels"This is because
metadatais used in a nesting field and usually Kubernetes serializesmetadatadirectly without the involvement of the CRD.In order to allow to specify any field withing the
ShootTemplatemetadatafield,x-kubernetes-preserve-unknown-fields: truehas to be set.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: