fix: avoid invalid condition reasons #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We use the k8s default
Condition
type, which not only requires a non-emptyReason
, but also validates it against a regex. To avoid issues, the ConditionUpdater just added a dummy reason if it was empty, for which it used the condition'sType
. The regex for type and reason differ, though: type allows.
but not:
, while for the reason, it is the other way around.This PR replaces
.
with:
when using the type default the condition reason.Which issue(s) this PR fixes:
Required for openmcp-project/openmcp-operator#115
(not a hard requirement, though, there is a workaround in place)
Special notes for your reviewer:
Release note: