feat: add name field to AccessRequest permissions #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diaphteiros
requested review from
ValentinGerlach,
maximiliantech and
robertgraeff
maximiliantech
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
OIDC AccessRequests can bind arbitrary users to (Cluster)Roles, which doesn't work if the ClusterRole has a name that is not known upon creation of the AccessRequest. Therefore added the possibility to overwrite the name of the generated (Cluster)Roles.
Which issue(s) this PR fixes:
Loosely related to openmcp-project/backlog#210
Special notes for your reviewer:
Release note: