refactor: OIDC validation and defaulting #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Improves validation and defaulting of the
OIDCProviderConfig
struct (used in AccessRequests and MCPv2 resources, as well as MCPv2 controller config):usernamePrefix
andgroupsPrefix
have been removed and are now always assumed to be<name>:
.name
is not allowed to be set tosystem
. This prevents impersonating k8s service accounts.name
has been fixed.issuer
andclientID
are now required and the former one must look like an URL.ValidatingAdmissionPolicy
which ensures that MCPv2s don't specify duplicate OIDC provider names and no OIDC provider that conflicts with the default one.default
before) and it is now defaulted toopenmcp
instead.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Release note: