Skip to content

fix: make either clusterRef of requestRef optional #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

fix: make either clusterRef of requestRef optional #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions api/clusters/v1alpha1/accessrequest_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,15 @@ type AccessRequestSpec struct {
// Exactly one of clusterRef or requestRef must be set.
// This value is immutable.
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="clusterRef is immutable"
ClusterRef NamespacedObjectReference `json:"clusterRef"`
// +optional
ClusterRef *NamespacedObjectReference `json:"clusterRef,omitempty"`

// RequestRef is the reference to the ClusterRequest for whose Cluster access is requested.
// Exactly one of clusterRef or requestRef must be set.
// This value is immutable.
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="requestRef is immutable"
RequestRef NamespacedObjectReference `json:"requestRef"`
// +optional
RequestRef *NamespacedObjectReference `json:"requestRef,omitempty"`

// Permissions are the requested permissions.
Permissions []PermissionsRequest `json:"permissions"`
Expand Down
12 changes: 10 additions & 2 deletions api/clusters/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions api/crds/manifests/clusters.openmcp.cloud_accessrequests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,7 @@ spec:
- message: requestRef is immutable
rule: self == oldSelf
required:
- clusterRef
- permissions
- requestRef
type: object
status:
description: AccessRequestStatus defines the observed state of AccessRequest
Expand Down