-
Notifications
You must be signed in to change notification settings - Fork 0
feat: advanced clusteraccess library #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR screams for some form of documentation of how to use it :-)
Expecially, what do I need to do to setup the requests for new and existing clusters.
How would the id, suffix and the callback function need to look like.
Maybe add an example for MCP, Workload and Onboarding clusters.
I can see some hints in the implementation of the already existing clusteraccess library. But for me it looks like some black magic is happening with al list of very precise steps that need to be done to set this up correctly. Just from the interface description I wouldn't be able to reproduce this.
Did you see the documentation here? |
I did not ... |
62e3779
to
6e586b7
Compare
Co-authored-by: René Schünemann <rene.schuenemann@sap.com>
…sterRegistrationBuilder constructors
6e586b7
to
9553bba
Compare
What this PR does / why we need it:
We have many controllers that reconcile something and then need access to a
Cluster
related to that something. I therefore liked the idea of theclusteraccess
library, but it was focused on the MCP use-case and too restricted to be used outside of that, e.g. for the dns platform service (which reconcilesCluster
resources that don't have to belong to an MCP).Therefore, I implemented a more flexible version of the library and modified the original implementation to just be a facade in front of the 'advanced' clusteraccess library with nearly (see below) no changes to its behavior.
Which issue(s) this PR fixes:
Fixes #143
Special notes for your reviewer:
The behavior of the 'simple' clusteraccess library has changed in one noticeable point: Before, it waited for the namespace to be created by requeuing until it existed. With the new implementation, it instead creates the namespace itself and does not requeue.
If this can be a problem somewhere, I can also adapt the implementation to keep the previous behavior.
Release note: