fix: requeue mcp if not ready #184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this, whether an MCPv2 was requeued or not solely depended on the readiness of all access variants configured in the MCP. Since the MCP syncs the conditions from its
Clusterand only becomesReadyif all conditions are healthy, it could happen that allAccessRequestsand related secrets became ready while theClusterstill had unhealthy conditions. This would then lead to the MCP being stuck inProgressinguntil a reconciliation was triggered somehow.With this PR, the MCP will be requeued for reconciliation if its phase is not
Ready, even when all configured accesses are already available. This prevents the aforementioned problem.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: