Skip to content

Conversation

@Diaphteiros
Copy link
Contributor

What this PR does / why we need it:
Before this, whether an MCPv2 was requeued or not solely depended on the readiness of all access variants configured in the MCP. Since the MCP syncs the conditions from its Cluster and only becomes Ready if all conditions are healthy, it could happen that all AccessRequests and related secrets became ready while the Cluster still had unhealthy conditions. This would then lead to the MCP being stuck in Progressing until a reconciliation was triggered somehow.

With this PR, the MCP will be requeued for reconciliation if its phase is not Ready, even when all configured accesses are already available. This prevents the aforementioned problem.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed a bug that caused an `MCPv2` to not be requeued for reconciliation despite not being `Ready` yet, causing it to be stuck in `Progressing` until a reconciliation was triggered externally.

@Diaphteiros Diaphteiros requested a review from reshnm October 14, 2025 11:51
@reshnm reshnm merged commit ca0794e into main Oct 14, 2025
5 checks passed
@reshnm reshnm deleted the mcp-readiness branch October 14, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants