feat: add apiserver endpoint to generic Cluster status #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diaphteiros
requested review from
ValentinGerlach,
maximiliantech,
reshnm and
robertgraeff
robertgraeff
approved these changes
Jun 2, 2025
|
|
||
| // APIServer is the API server endpoint of the cluster. | ||
| // +optional | ||
| APIServer string `json:"apiServer,omitempty"` |
There was a problem hiding this comment.
Since the field is optional, should the string rather be *string?
Suggested change
| APIServer string `json:"apiServer,omitempty"` | |
| APIServer *string `json:"apiServer,omitempty"` |
There was a problem hiding this comment.
I think the +optional doesn't do anything in this case.
I would prefer to work with string instead of *string, because it is easier (one doesn't have to check for nil pointers all the time).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: