add common api package #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reshnm
previously approved these changes
Jul 14, 2025
reshnm
approved these changes
Jul 16, 2025
maximiliantech
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a
commonapi package with structs that can be reused across multiple projects in the openmcp org.Which issue(s) this PR fixes:
Part of #70
Special notes for your reviewer:
I didn't replace the current structs by the new common ones on purpose, because there are some interactions with the controller-utils library. It is easier to just add the new structs, then adapt controller-utils, and then replace the existing ones with the new ones in a separate PR.
Release note: