Feature/status filter column #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hubert-Szczepanski-SAP
force-pushed
the
feature/status-filter-column
branch
from
f13e2d8 to
62978c5
Compare
lucasgoral
previously approved these changes
Jun 17, 2025
| column.setFilter(val === 'all' ? undefined : val); | ||
| }; | ||
|
|
||
| const renderOption = ({ |
There was a problem hiding this comment.
This is a component defined inside another component, isn’t it? That’s usually not recommended in React. Consider moving it outside the component. That said, if we really need access to the parent’s props or state and the component is pretty small, it’s usually fine. Just a heads-up
There was a problem hiding this comment.
Pushed changes
lucasgoral
previously approved these changes
Jun 17, 2025
lucasgoral
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: