Skip to content

Bugfix/adding click here link to feedback #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025
Merged

Bugfix/adding click here link to feedback #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
123eb68
Adding click here link to the feedback
Hubert-Szczepanski-SAP Jul 8, 2025
d73884f
Removing unused code
Hubert-Szczepanski-SAP Jul 9, 2025
b4e4c0a
Removing unused variable and adding proper Ui5 component
Hubert-Szczepanski-SAP Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion public/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@
"feedbackButton": "Send feedback",
"feedbackButtonInfo": "Give us your feedback",
"feedbackPlaceholder": "Please let us know what you think about our application",
"feedbackNotification": "*Slack notification with your email address will be shared with our Operations Team. If you have a special Feature request in mind, please create here.",
"feedbackNotificationText": "*Slack notification with your email address will be shared with our Operations Team. If you have a special Feature request in mind ",
"feedbackNotificationAction": "click here.",
"feedbackThanks": "Thank you for your feedback!"
},
"CreateProjectDialog": {
Expand Down
17 changes: 10 additions & 7 deletions src/components/Core/ShellBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
FormItem,
Icon,
Label,
Link,
List,
ListItemStandard,
Popover,
Expand Down Expand Up @@ -36,7 +37,6 @@ import { generateInitialsForEmail } from '../Helper/generateInitialsForEmail.ts'
import styles from './ShellBar.module.css';
import { ThemingParameters } from '@ui5/webcomponents-react-base';
import { ShellBarItemClickEventDetail } from '@ui5/webcomponents-fiori/dist/ShellBarItem.js';
import { t } from 'i18next';

type UI5RatingIndicatorElement = HTMLElement & { value: number };

Expand Down Expand Up @@ -149,11 +149,7 @@ export function ShellBarComponent() {
}
onProfileClick={onProfileClick}
>
<ShellBarItem
icon="feedback"
text={t('ShellBar.feedbackNotification')}
onClick={onFeedbackClick}
/>
<ShellBarItem icon="feedback" onClick={onFeedbackClick} />
</ShellBar>

<ProfilePopover
Expand Down Expand Up @@ -336,7 +332,14 @@ const FeedbackPopover = ({
</FormItem>
<FormItem>
<Label style={{ color: 'gray' }}>
{t('ShellBar.feedbackNotification')}
{t('ShellBar.feedbackNotificationText')}
<Link
href="https://github.com/openmcp-project/ui-frontend/issues/new/choose"
target="_blank"
rel="noreferrer"
>
{t('ShellBar.feedbackNotificationAction')}
</Link>
</Label>
</FormItem>
</FormGroup>
Expand Down
Loading