Feat: delete project dialog #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaskienle
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
Looks good!
I only noticed some minor things. Since you’re on holiday 🌴, I’ve immediately fixed them.
I've also made some changes to the <DeleteConfirmationDialog>:
- removed the duplicate text
- changed the wording a bit
- moved the Kubectl button to the bottom to be in line with other dialogs
Before:
After:
src/components/Dialogs/KubectlCommandInfo/Controllers/KubectlDeleteProject.tsx
Outdated
Show resolved
Hide resolved
src/components/Dialogs/KubectlCommandInfo/KubectlDeleteProjectDialog.tsx
Outdated
Show resolved
Hide resolved
src/components/Dialogs/KubectlCommandInfo/KubectlDeleteProjectDialog.tsx
Outdated
Show resolved
Hide resolved
src/components/Dialogs/KubectlCommandInfo/KubectlDeleteProjectDialog.tsx
Outdated
Show resolved
Hide resolved
Hubert-Szczepanski-SAP
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows delete Projects from UI
fixes openmcp-project/backlog#128