fix(sentry): remove sendDefaultPii option to enhance privacy #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances privacy by removing the sendDefaultPii option from Sentry configurations across both client-side and server-side code, preventing automatic collection of personally identifiable information such as IP addresses.
- Removed
sendDefaultPii: truefrom client-side Sentry initialization in TypeScript - Removed
sendDefaultPii: truefrom server-side Sentry initialization in JavaScript - Eliminated associated comments explaining the PII collection behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mount.ts | Removed sendDefaultPii option from client-side Sentry configuration |
| server.js | Removed sendDefaultPii option from server-side Sentry configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
sendDefaultPiioption from Sentry initialization in both the server and client codebases, ensuring that default Personally Identifiable Information (PII) is no longer sent to Sentry.Changes related to Sentry configuration:
server.js: Removed thesendDefaultPiioption from the Sentry initialization, which previously allowed automatic PII data collection, such as IP addresses, when enabled.src/mount.ts: Removed thesendDefaultPiioption from the Sentry initialization in the client-side setup, aligning it with the updated privacy policy.