[To discuss] Move inline styles to CSS module #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasgoral
reviewed
Mar 26, 2025
andreaskienle
changed the title
This was referenced Mar 31, 2025
Closed
lucasgoral
approved these changes
Apr 4, 2025
enrico-kaack-comp
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR illustrates how we could use CSS modules.
See also: #25, #30
Since we've decided to use CSS modules 🎉, I've put both the CSS and TSX files into a folder and I've updated the styles to use rem instead of pixels. It’s now ready for review and we could merge it then.