fix: banner sizing on workspace #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes banner sizing issues on workspace views by making error banners more compact. The banners were previously too large and this change reduces their size to be more appropriate for the UI context.
- Changes the compact design from ExtraSmall to Small for IllustratedBanner component
- Adds compact prop support to IllustratedError component
- Applies compact styling to error banners across workspace-related components
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/Ui/IllustratedBanner/IllustratedBanner.tsx | Updates compact design size from ExtraSmall to Small |
| src/components/Shared/IllustratedError.tsx | Adds compact prop support and passes it through to IllustratedBanner |
| src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx | Enables compact mode for permission error banner |
| src/components/ControlPlane/FluxList.tsx | Enables compact mode for flux error banner |
| src/components/ComponentsSelection/ComponentsSelectionContainer.tsx | Enables compact mode for component loading error banners |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the banner have been very large. This fixes it in this section.
